Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "NodeController waits for informer sync before doing a… #34857

Merged
merged 1 commit into from
Oct 14, 2016
Merged

Revert "Revert "NodeController waits for informer sync before doing a… #34857

merged 1 commit into from
Oct 14, 2016

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Oct 14, 2016 •
edited

reverts #34849 adding back #34809

This change is Reviewable

@jessfraz jessfraz added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Oct 14, 2016
@jessfraz jessfraz added this to the v1.4 milestone Oct 14, 2016
@wojtek-t
Copy link
Member

/lgtm

@jessfraz jessfraz added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 14, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 14, 2016
@bprashanth
Copy link
Contributor

I haven't been following the revert revert game close enough but looks ok, and wojtek-t's lgtm is good enough so applying label

@bprashanth bprashanth added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 746e7d7. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@bprashanth
Copy link
Contributor 

    ingress_controller_test.go:166: Checking that the configmap in cluster 2 got updated.
PASS
Found 1 data race(s)
FAIL    k8s.io/kubernetes/federation/pkg/federation-controller/ingress  2.343s

#33558

@bprashanth
Copy link
Contributor

@k8s-bot unit test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 746e7d7. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@jessfraz jessfraz merged commit 3a4347c into kubernetes:release-1.4 Oct 14, 2016
@jessfraz jessfraz deleted the fixes branch October 14, 2016 21:42
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@jessfraz
Merge pull request kubernetes#34857 from jessfraz/fixes
a1361e3 
Revert "Revert "NodeController waits for informer sync before doing a…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bprashanth bprashanth

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jessfraz @wojtek-t @bprashanth @k8s-ci-robot @k8s-cherrypick-bot @googlebot @k8s-github-robot